Skip to content

[Tools] Use const& and std::move to avoid copies - #17714

Merged
ktf merged 1 commit into
AliceO2Group:masterfrom
vkucera:const-Tools
Sep 3, 2026
Merged

[Tools] Use const& and std::move to avoid copies#17714
ktf merged 1 commit into
AliceO2Group:masterfrom
vkucera:const-Tools

Conversation

@vkucera

@vkucera vkucera commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Mostly done automatically by Clang-Tidy.

Mostly done automatically by Clang-Tidy.
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 96 errors, ⚠️ 140 warnings, 🔕 2 disabled

@github-actions github-actions Bot added the tools label Sep 1, 2026
@github-actions github-actions Bot changed the title Use const& and std::move to avoid copies [Tools] Use const& and std::move to avoid copies Sep 1, 2026
@vkucera
vkucera marked this pull request as ready for review September 1, 2026 15:54
@alibuild

alibuild commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 81fc954 at 2026-09-03 02:57:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 28 errors and 48 warnings.'
Found 28 errors and 48 warnings.
++ [[ 28 -gt 0 ]]
++ cat /sw/BUILD/1696d36b05c14aa08e3c206c5f80f87a0b09d780/O2Physics-code-check/errors.txt
Tools/KFparticle/KFUtilities.h:88:26: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/KFparticle/KFUtilities.h:153:19: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/KFparticle/KFUtilities.h:337:26: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/KFparticle/KFUtilities.h:349:26: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/KFparticle/KFUtilities.h:363:34: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/KFparticle/KFUtilities.h:363:38: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/KFparticle/KFUtilities.h:364:27: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/KFparticle/KFUtilities.h:364:36: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/KFparticle/KFUtilities.h:364:45: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/KFparticle/KFUtilities.h:365:27: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/KFparticle/KFUtilities.h:365:36: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/KFparticle/KFUtilities.h:365:45: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/KFparticle/KFUtilities.h:381:20: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/KFparticle/qaKFEventTrack.cxx:59:8: error: constructor does not initialize these fields: ccdb, lut, runNumber [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
Tools/KFparticle/qaKFEventTrack.cxx:515:8: error: constructor does not initialize these fields: ccdb, lut, runNumber [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
Tools/KFparticle/qaKFEventTrack.cxx:632:18: error: narrowing conversion from 'unwrap_t<float>' (aka 'float') to 'uint64_t' (aka 'unsigned long') [bugprone-narrowing-conversions,-warnings-as-errors]
Tools/KFparticle/qaKFParticleLc.cxx:58:8: error: constructor does not initialize these fields: ccdb, lut, runNumber [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
Tools/KFparticle/qaKFParticleLc.cxx:254:20: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/KFparticle/qaKFParticleLc.cxx:349:109: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
Tools/KFparticle/qaKFParticleLc.cxx:368:109: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
Tools/KFparticle/qaKFParticleLc.cxx:387:109: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
Tools/KFparticle/qaKFParticle.cxx:64:8: error: constructor does not initialize these fields: ccdb, pdgdb, lut, runNumber [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
Tools/KFparticle/qaKFParticle.cxx:460:114: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
Tools/KFparticle/qaKFParticle.cxx:479:114: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
Tools/KFparticle/qaKFParticle.cxx:791:27: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/KFparticle/qaKFParticle.cxx:826:30: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/KFparticle/qaKFParticle.cxx:1098:27: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/KFparticle/qaKFParticle.cxx:1138:30: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
++ [[ 48 -gt 0 ]]
++ cat /sw/BUILD/1696d36b05c14aa08e3c206c5f80f87a0b09d780/O2Physics-code-check/warnings.txt
Tools/KFparticle/KFUtilities.h:85:9: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Tools/KFparticle/KFUtilities.h:132:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Tools/KFparticle/KFUtilities.h:303:51: warning: statement should be inside braces [readability-braces-around-statements]
Tools/KFparticle/KFUtilities.h:306:24: warning: statement should be inside braces [readability-braces-around-statements]
Tools/KFparticle/KFUtilities.h:321:51: warning: statement should be inside braces [readability-braces-around-statements]
Tools/KFparticle/KFUtilities.h:324:24: warning: statement should be inside braces [readability-braces-around-statements]
Tools/KFparticle/KFUtilities.h:335:9: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Tools/KFparticle/KFUtilities.h:347:9: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Tools/KFparticle/KFUtilities.h:359:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Tools/KFparticle/KFUtilities.h:360:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Tools/KFparticle/KFUtilities.h:361:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Tools/KFparticle/KFUtilities.h:362:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
[0 more errors; see full log]

Full log here.

@ktf

ktf commented Sep 3, 2026

Copy link
Copy Markdown
Member

Trivial. Merging.

@ktf
ktf merged commit 7c846b4 into AliceO2Group:master Sep 3, 2026
10 of 13 checks passed
@vkucera
vkucera deleted the const-Tools branch September 3, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants